For trains and buses, as far in advance as possible to ensure availability. For flights, there’s a “sweet spot” in many countries between paying too much for advance and too much for last-minute. Check the airline web sites frequently for special offers. You could save a small fortune with several of them if you’re prepared to schedule your trip around discounts.